Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: biome #118

Closed
wants to merge 3 commits into from
Closed

Feat: biome #118

wants to merge 3 commits into from

Conversation

simonorzel26
Copy link
Collaborator

@simonorzel26 simonorzel26 commented Apr 5, 2024 •
edited
Loading

In this PR I initialized biome with a focus on as little regression as possible in the formatting and linting. I did this by turning off as many format and lint rules in biome as needed in order to change as few files/lines as possible from the previous setup.

In a future PR we can and probably should try to remove some ignored rules in the biome file, especially the security and suspicious rules. However, that will mean changing lots of working code, which I wanted to keep out of this PR.

@vercel Vercel
Copy link

vercel bot commented Apr 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
abby-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2024 2:58pm

@vercel Vercel
Copy link

vercel bot commented Apr 5, 2024

@simonorzel26 is attempting to deploy a commit to a Personal Account owned by @tryabby on Vercel.

@tryabby first needs to authorize it.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 5, 2024

Important

Auto Review Skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

209 files out of 294 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@simonorzel26 simonorzel26 linked an issue Apr 5, 2024 that may be closed by this pull request
Migrate from Eslint & Prettier to Biome #114
Closed
@simonorzel26
Copy link
Collaborator Author

#TODO fix angular support (need help)

@simonorzel26 simonorzel26 requested a review from cstrnt April 5, 2024 15:00
@simonorzel26
Copy link
Collaborator Author

Should we scrap this and try npx @biomejs/biome migrate @cstrnt

@cstrnt cstrnt closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstrnt cstrnt Awaiting requested review from cstrnt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate from Eslint & Prettier to Biome
2 participants
@simonorzel26 @cstrnt